Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the GLA button styles from overriding other styles or being overridden by other styles #1391

Closed
eason9487 opened this issue Apr 1, 2022 · 1 comment
Labels
type: bug The issue is a confirmed bug. type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@eason9487
Copy link
Member

eason9487 commented Apr 1, 2022

Describe the bug:

  1. The GLA button styles might override other styles out of GLA pages.
  2. The GLA button styles are overridden by other styles.

Steps to reproduce:

Overrides others

  1. Go to Marketing -> Overview
  2. Run script via DevTool console:
    {
    	const button = document.createElement('button');
    	button.innerText = 'Howdy!';
    	button.classList.add( 'components-button', 'is-destructive', 'is-link' );
    	document.querySelector('#woocommerce-layout__notice-list').appendChild( button );
    }
  3. The styles of just created "Howdy!" button is overridden by GLA styles.
    2022-04-01 12 45 38

Being overridden by others

#1374 (comment)

Crazy, it comes from Automatewoo

Screenshot 2022-03-31 at 15 52 46 Screenshot 2022-03-31 at 15 55 04

Expected behavior:

The the GLA button styles should avoid conflict with other styles

Actual behavior:

Conflicts between the GLA button styles and other styles

@eason9487
Copy link
Member Author

Closing this issue:

  1. The GLA button styles might override other styles out of GLA pages.

This extension has been made to not override the button styles on other pages by #1834.

  1. The GLA button styles are overridden by other styles.

With the release of AutomateWoo 6.0.6, AutomateWoo no longer overrides the button styles on other pages. In other extensions maintained by the team Automata, there are no known button style conflicts for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug. type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

No branches or pull requests

1 participant