Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-calendar__tile--active stays on even if value was cleared #944

Open
2 tasks done
lemontini opened this issue Jul 23, 2024 · 2 comments
Open
2 tasks done

react-calendar__tile--active stays on even if value was cleared #944

lemontini opened this issue Jul 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lemontini
Copy link

Before you start - checklist

  • I followed instructions in documentation written for my React-Calendar version
  • I have checked if this bug is not already reported

Description

The class indicating active ("selected") state of a tile in month view (class react-calendar__tile--active) is not removed if the value supplied to react-calendar is cleared (e.g. setValue(undefined)).
The only workaround is to use tileClassName and set the custom selected class to style active ("selected") day accordingly.

Steps to reproduce

screen recording provided.

Expected behavior

react-calendar__tile--active is removed from all tiles, as no value is selected (value=undefined)

Actual behavior

react-calendar__tile--active stays on corresponding day tile

Additional information

screen recording:
https://github.com/user-attachments/assets/d83076fa-a51a-47ce-9304-af446d6581d8

Environment

  • Browser (if applicable): Chrome 126.0.6478.183
  • React-Calendar version: 5.0.0
  • React version: 18.0.0
@lemontini lemontini added the bug Something isn't working label Jul 23, 2024
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 28, 2024
@lucasriondel
Copy link

This should not be closed as this is not resolved

@github-actions github-actions bot removed the stale label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants