Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Timer doesn't refresh when updating the same toast. #42

Closed
themixednuts opened this issue Jan 5, 2024 · 2 comments
Closed

bug: Timer doesn't refresh when updating the same toast. #42

themixednuts opened this issue Jan 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@themixednuts
Copy link

When updating the same toast via toast.id, the timer doesn't refresh so toast will disappear after the original duration expires. Should reset the timer per update.

@wobsoriano
Copy link
Owner

Related to #35

@wobsoriano wobsoriano added the bug Something isn't working label Jan 5, 2024
@huntabyte
Copy link
Collaborator

huntabyte commented Jan 6, 2024

I'm not sure if it makes sense to reset the timer on update if a duration isn't passed with that update. What if my intention is to keep the toast for the same total duration, but update the appearance part of the way through? Would this still be possible?

Edit: meh maybe it does make sense, as it feels like the intuitive thing when updating to basically swap a toast with a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants