feat(hamt): diff and merge implementation #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 69.29% 68.80% -0.50%
==========================================
Files 27 32 +5
Lines 2013 2366 +353
Branches 471 586 +115
==========================================
+ Hits 1395 1628 +233
- Misses 239 265 +26
- Partials 379 473 +94
|
- lean diff method that focuses on the tree - exhaustive diff that holds a copy of changed key value pairs
appcypher
force-pushed
the
appcypher/hamt-diff
branch
from
c4978a5
to
fc2a592
Compare
- Add some docs - Not satisfied with the proptests yet
matheus23
reviewed
Dec 12, 2022
- Implement merge for `Node<k, V, H>` - Add more proptests, unittests and docs
- Remove hashbrown crate Co-authored-by: Philipp Krüger <[email protected]>
appcypher
changed the title
matheus23
reviewed
Dec 16, 2022
- Simplify tests - UnwrapOrClone trait - Prefer once_cell - Remove depth param from diff
- Remove version checks in hamt - CHange HashKey to HashPrefix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements diffing algos for observing the differences between two HAMT roots.
This PR implements the following features
Others
Test plan (required)
Testing
rs-wnfs test --allClosing issues
Fixes #92
Fixes #93