Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bench): Update criterion to 0.5 #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matheus23
Copy link
Member

Closes #456

@matheus23 matheus23 self-assigned this Sep 27, 2024
@matheus23 matheus23 requested a review from a team as a code owner September 27, 2024 08:46
@matheus23 matheus23 enabled auto-merge (squash) September 27, 2024 08:46
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.07%. Comparing base (85f3e6c) to head (5b38d3a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   55.99%   56.07%   +0.07%     
==========================================
  Files          58       58              
  Lines        4434     4428       -6     
  Branches     1113     1122       +9     
==========================================
  Hits         2483     2483              
+ Misses       1207     1199       -8     
- Partials      744      746       +2     

see 16 files with indirect coverage changes

@appcypher
Copy link
Member

nightly clippy is having a fit again.

Copy link
Member

@appcypher appcypher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheus23
Copy link
Member Author

Yeah, that and we need to fix wasm-bindgen-cli version mismatches for the Wasm build 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0375: atty is unmaintained
2 participants