fix: get_node should return null on missing path #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rs-wnfs
get_node
fns inPublicDirectory
andPrivateDirectory
currently do not replicate the same behavior in webnative when a non-existent path segment is specified. It returns anErr(...)
instead of aOk(None)
which translates tonull
on the js side.This PR solves that although there is the little inconvenience that wasm-bindgen translates
Ok(None)
toundefined
on the js side.Test plan (required)
scripts/rs-wnfs.sh test
Closing issues
Fixes #222