We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockStore
Some feedback from dig:
bytes::Bytes
no_std
IpldCodec
libipld
u64
put_block
&self
&mut self
cc @organizedgrime @laudiacay because I know you were looking at blockstore stuff too.
The text was updated successfully, but these errors were encountered:
i agree with point 2 & 3 don't have an opinion on 1
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Some feedback from dig:
bytes::Bytes
forBlockStore
is not a terrible idea. It's evenno_std
.IpldCodec
is pulling in a perhaps unnecessarily heavy dependency onlibipld
. What about making that simply au64
?put_block
in practice is often taking&self
instead of&mut self
, since most people put concurrency primitives inside of their blockstore.cc @organizedgrime @laudiacay because I know you were looking at blockstore stuff too.
The text was updated successfully, but these errors were encountered: