Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback refactor: BlockStore restructure #251

Closed
3 tasks done
matheus23 opened this issue May 3, 2023 · 1 comment · Fixed by #286
Closed
3 tasks done

Feedback refactor: BlockStore restructure #251

matheus23 opened this issue May 3, 2023 · 1 comment · Fixed by #286

Comments

@matheus23
Copy link
Member

matheus23 commented May 3, 2023

Some feedback from dig:

  • Adopting bytes::Bytes for BlockStore is not a terrible idea. It's even no_std.
  • IpldCodec is pulling in a perhaps unnecessarily heavy dependency on libipld. What about making that simply a u64?
  • put_block in practice is often taking &self instead of &mut self, since most people put concurrency primitives inside of their blockstore.

cc @organizedgrime @laudiacay because I know you were looking at blockstore stuff too.

@laudiacay
Copy link
Contributor

i agree with point 2 & 3
don't have an opinion on 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants