Add as_file and is_file to PrivateNode (wasm) #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
approved these changes
Jan 10, 2023
icidasset
force-pushed
the
icidasset/private-as_file
branch
from
220bd8c to
6bda654
Compare
icidasset
changed the title
|
Easily fixed 👍 |
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 68.95% 68.91% -0.04%
==========================================
Files 33 33
Lines 2503 2503
Branches 625 625
==========================================
- Hits 1726 1725 -1
- Misses 265 267 +2
+ Partials 512 511 -1
|
|
Tests run through fine. Feel free to hit the button when you're ready :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
as_fileandis_filefunctions to thePrivateNodeimplementation in the WASM package so that it matches thePublicNodeimplementation.Closing issues
Closes #130