viewportSize not reflected in API

[bornste]

The setting viewportSize cannot be set by the API because it is missing in the ReflectImpl<PdfGlobal> struct.

[rdvojmoc]

Can we expect setting viewportSize to come back to API at some point?

[ashkulz]

@rdvojmoc: would be happy to receive a PR, it's a very small fix 😄

[OskarStark]

@ashkulz as this this issue already has a merged PR (#3440) we can close is.

After closing this issue, the Milestone for 0.12.5 is completed. A new release would be great 👍

[melroy89]

@ashkulz YEA release 0.12.5! plz? 😄

[OskarStark]

can you please create a release?

[MrMitch]

@ashkulz Hi, thanks for your work on this project.
It seems that PR #3440 implements this, and it has been merged. This was the last issue for the 0.12.5 milestone, so do you know if there's anything more that needs to be contributed for a release ?
The 0.12.5 release is especially awaited because it solves #3241 which has be problematic on Linux and Mac for more than a year now.
How can we help ?

[OskarStark]

Can you guys please create a release?

[ashkulz]

Currently working on a reworked packaging system in the wkhtmltopdf/packaging repository, you can download preview builds for linux. For OS X and Windows, trying to automate the build using vagrant so a release can be created easily.

Planning to release a -rc by next weekend, and a release after a week .. so expect May 15 for the 0.12.5 release.

[ashkulz]

A release candidate is available which includes the fixes made in PR #3440 -- please test and report your findings before the final release.

[OskarStark]

hey @ashkulz thank you 👍

could you make the RC available on github releases:
https://github.com/wkhtmltopdf/wkhtmltopdf/releases

[ashkulz]

I plan to make only the final release available, as no one cares for -rc after that. No point in wasting storage space...

[OskarStark]

ok thank you