Allow disabling graphical crash handler with --no-crash-dialog

This is mainly for running Picard in CI environments and debugging

Author: phw

.github/workflows/run-tests.yml

@@ -110,7 +110,7 @@ jobs:
         pip install .
     - name: Test running installed package
       if: runner.os != 'Windows'
-      run: picard --long-version
+      run: picard --long-version --no-crash-dialog
     - name: Verify sdist package
       if: runner.os != 'Windows'
       run: |

picard/__init__.py

@@ -96,9 +96,14 @@ def crash_handler():
     a minimal crash dialog to the user.
     This function is supposed to be called from inside an except blog.
     """
+    import sys
+
+    # Allow disabling the graphical crash handler for debugging and CI purposes.
+    if '--no-crash-dialog' in sys.argv:
+        return
+
     # First try to get traceback information and write it to a log file
     # with minimum chance to fail.
-    import sys
     from tempfile import NamedTemporaryFile
     import traceback
     trace = traceback.format_exc()

picard/tagger.py

@@ -949,6 +949,8 @@ def process_picard_args():
                         help="do not restore positions and/or sizes")
     parser.add_argument("-P", "--no-plugins", action='store_true',
                         help="do not load any plugins")
+    parser.add_argument("--no-crash-dialog", action='store_true',
+                        help="disable the crash dialog")
     parser.add_argument('-v', '--version', action='store_true',
                         help="display version information and exit")
     parser.add_argument("-V", "--long-version", action='store_true',

scripts/package/macos-package-app.sh

@@ -83,7 +83,7 @@ fi
 # Only test the app if it was codesigned, otherwise execution likely fails
 if [ "$CODESIGN" = '1' ]; then
   echo "Verify Picard executable works and required dependencies are bundled..."
-  VERSIONS=$("$APP_BUNDLE/Contents/MacOS/picard-run" --long-version)
+  VERSIONS=$("$APP_BUNDLE/Contents/MacOS/picard-run" --long-version --no-crash-dialog)
   echo "$VERSIONS"
   ASTRCMP_REGEX="astrcmp C"
   [[ $VERSIONS =~ $ASTRCMP_REGEX ]] || (echo "Failed: Build does not include astrcmp C" && false)