Unconditional debug output console.log(source, material); may affect performance

[sompylasar]

The debug output should only run in some debug mode (you could use the debug package for that).

aframe-effects/systems/effects.js

Lines 260 to 270 in 776d69f

	var material = this.materialize({
	fragmentShader: source,
	uniforms: uniforms
	});
	console.log(source, material);
	return material;
	},
	rebuild: function () {
	var self = this, passes = [], temp = [];

aframe-effects/dist/aframe-effects.js

Lines 496 to 516 in c4f9cdb

	head.join("\n"), chunks.join("\n"), "\n",
	premain.join("\n"), main.join("\n"),
	alpha ? " gl_FragColor = color;" : " gl_FragColor = vec4(color.rgb, 1.0);", "}"
	].join("\n");
	var material = this.materialize({
	fragmentShader: source,
	uniforms: uniforms
	});
	console.log(source, material);
	return material;
	},
	rebuild: function () {
	var self = this, passes = [], temp = [];
	this.passes.forEach(function(pass){
	if (pass.dispose) pass.dispose();
	});
	this.data.forEach(function (k) {
	if(!k){

[wizgrav]

You're right, I think an approach could be to check if the debug component is set on the a-scene element. Thanks for noticing

[sompylasar]

an approach could be to check if the debug component is set on the a-scene element.

Querying the browser DOM is slow compared to querying a JS variable. Especially repeatedly.

[sompylasar]

But of course both approached should be benchmarked to find the most performant.

Using the de-facto standard debug module lets the users to remove the debug calls in production builds. Using the a-scene debug component may require extra dancing to strip that out.

[wizgrav]

Ok, can you submit a PR?