-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big pixel ladders #12
Comments
I'm not sure if the resolution actually decreases or it's just that the native antialiasing is disabled, I'll have to test a bit as I haven't touched the code in a while. Can you try appending the "fxaa" component at the end of the effects chain? |
@brianconnoly which effects are you trying to use? Could you post an, even simplified, example somewhere to inspect? |
I used bloom and fxaa. |
I had the exactly the same problem. seems like if you use image in aframe and apply post processing, the resolution significantly drops on mobile device. PC works fine. |
It looks like most of the pipeline setup is basing buffer size off of renderer.getSize(), however modern mobile devices (and now more and more laptops and pro PC monitors) have a pixel ratio of 2 or 3. This would precisely explain the downres, although I don't have the time or understanding to comb over all the places buffers are allocated or updated, and I can't find a quick effective central point to update renderer.getSize() width & height with a *= renderer.getPixelRatio(). |
When using this components, seems that resolution of rendering divides by two.
Before effects:
After effects:
And how can I get rid of that dirty black noise where walls connects to ceiling?
The text was updated successfully, but these errors were encountered: