Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] allow config extension #884

Merged
merged 2 commits into from
Oct 22, 2018
Merged

[Android] allow config extension #884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
305b3f9
android config ext from root
matteo-hertel Aug 13, 2018
f69c41f
Merge branch 'master' into master
noomorph Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions detox/android/detox/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
apply plugin: 'com.android.library'

def _ext = rootProject.ext;

def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 25;
def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '27.0.3';
def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 18;
def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 25;

android {
compileSdkVersion 25
buildToolsVersion '27.0.3'
compileSdkVersion _compileSdkVersion
buildToolsVersion _buildToolsVersion
defaultConfig {
minSdkVersion 18
targetSdkVersion 25
minSdkVersion _minSdkVersion
targetSdkVersion _targetSdkVersion
versionCode 1
versionName "1.0"
}
Expand Down