Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detox definitions #99

Closed
Gongreg opened this issue Mar 16, 2017 · 9 comments
Closed

Add detox definitions #99

Gongreg opened this issue Mar 16, 2017 · 9 comments

Comments

@Gongreg
Copy link

Gongreg commented Mar 16, 2017

Having IDE support would really help writing tests. Since we have a lot of people liking typescript, something like DefinitelyTyped would help.

@rotemmiz
Copy link
Member

Great suggestion! I love it. We'll put it in our plan.
Alternatively, you can submit a PR, that would be very much appreciated.

@TareqElMasriDev
Copy link
Contributor

I made the definitions, it's documented with examples, I'm waiting for the pull request to get approved, when it gets published, it will be used via npm install @types/detox
https://github.com/TareqElMasri/DefinitelyTyped/tree/master/types/detox

@tachtevrenidis
Copy link

did this PR ever make it in?

@DanielMSchmidt
Copy link
Contributor

@tachtevrenidis There are still review comments, but it looks great otherwise 👍

@TareqElMasriDev
Copy link
Contributor

Goodnews everyone, the PR made it successfully, now the maintainers need to create npm package for @types/detox using Types publisher tool
DefinitelyTyped/DefinitelyTyped#25005 (comment)

@rotemmiz
Copy link
Member

Hooray! Let's add this to docs and close this issue.

@TareqElMasriDev
Copy link
Contributor

Fellas, it's up and running
https://www.npmjs.com/package/@types/detox

@DanielMSchmidt
Copy link
Contributor

Awesome 👍 Let's close this issue then <3

@zibs
Copy link

zibs commented Jul 3, 2018

Super awesome! Thanks for setting this up;

My only question is how to prevent the detox types from over-riding my jest types? Since detox overrides the jest object, it seems like when I'm trying to just write normal jest tests, TS still thinks the jest object is a detox one and so it complains for all the normal jest matchers/expects etc:

[ts] Property 'toEqual' does not exist on type 'Expect<any>'.

It's only small issue, so I don't feel like opening a new issue for it, but just curious if anyone has any ideas.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants