-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detox definitions #99
Comments
Great suggestion! I love it. We'll put it in our plan. |
I made the definitions, it's documented with examples, I'm waiting for the pull request to get approved, when it gets published, it will be used via |
did this PR ever make it in? |
@tachtevrenidis There are still review comments, but it looks great otherwise 👍 |
Goodnews everyone, the PR made it successfully, now the maintainers need to create npm package for |
Hooray! Let's add this to docs and close this issue. |
Fellas, it's up and running |
Awesome 👍 Let's close this issue then <3 |
Super awesome! Thanks for setting this up; My only question is how to prevent the detox types from over-riding my jest types? Since detox overrides the jest object, it seems like when I'm trying to just write normal jest tests, TS still thinks the jest object is a detox one and so it complains for all the normal jest matchers/expects etc:
It's only small issue, so I don't feel like opening a new issue for it, but just curious if anyone has any ideas. |
Having IDE support would really help writing tests. Since we have a lot of people liking typescript, something like DefinitelyTyped would help.
The text was updated successfully, but these errors were encountered: