Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox scrolls warning area instead of real ListView #85

Closed
ihork opened this issue Jan 24, 2017 · 4 comments
Closed

Detox scrolls warning area instead of real ListView #85

ihork opened this issue Jan 24, 2017 · 4 comments

Comments

@rotemmiz
Copy link
Member

rotemmiz commented Jun 5, 2017

I think the issue revolves around the manipulation we do in this matcher:
https://github.com/wix/detox/blob/master/detox/ios/Detox/GREYMatchers%2BDetox.m#L68

@silyevsk
Copy link
Contributor

silyevsk commented Jun 6, 2017

The element matcher works fine and finds the correct scroll view. But the scroll action starts at the bottom of the scroll view which is covered with the warning view.

To workaround this, it's possible to disable react native warnings in Javascript with console. disableYellowBox = true

In react native 0.44 the warning is disabled in test environment by default, and the test environment is on in detox (RN enables it if XCTest class exists which is loaded by EG).

While we don't have much to do with warnings specifically (because it's solved in recent RN and there's a workaround), the issue with EarlGrey should be still addressed, because it can happen for any covering view which reacts to pan gestures, and probably also for tap actions on overlapping views that react to taps (e.g. a button covering a view that reacts to taps).

@LeoNatan
Copy link
Contributor

LeoNatan commented Jun 6, 2017

I think the workaround, together with the default mode in modern RN, is a good enough solution to this problem right now. In the future, once we implement #154, the problem here will be moot, as the user will be able to specify where to start the scroll (pan) action, avoiding any clipping views, such as the warning area.

@LeoNatan LeoNatan closed this as completed Jun 6, 2017
@silyevsk
Copy link
Contributor

silyevsk commented Jun 7, 2017

EarlGrey issue: google/EarlGrey#532

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants