Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm run build - builds the framework without any console messages #77

Closed
talkol opened this issue Jan 12, 2017 · 2 comments
Closed

npm run build - builds the framework without any console messages #77

talkol opened this issue Jan 12, 2017 · 2 comments
Assignees
@talkol
Labels
type: question/stack overflow

Comments

@talkol
Copy link

talkol commented Jan 12, 2017

why did we add this step?

we should at least add a message that this is being built
@talkol talkol self-assigned this Jan 12, 2017
@LeoNatan
Copy link
Contributor

LeoNatan commented Jan 12, 2017 •
edited
Loading

@talkol We needed the Detox source to be in a specific place in order to build a .framework on the client side in postinstall. Since that cannot be guaranteed (wonders of npm / yarn), we now build it before publish.

@LeoNatan
Copy link
Contributor

Fixed with 03b0988

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@talkol talkol

Labels
type: question/stack overflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeoNatan @talkol