-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detox preStart script in config json #60
Comments
You can achieve this with a script already. @rotemmiz Do you think we should implement? |
This may be a good idea for running short lived tasks, but running servers is a pretty complex thing to deal with. We would need to save the forked process id and make sure it is killed when Detox dies. Starting to listen on signals and creating a complex mechanism for cleanup is not something I think Detox should be focused around. Instead, I suggest that running mock servers (Node servers) will be a part of your test case, as such: https://github.com/wix/detox/blob/master/detox/test/e2e/m-network.js |
@rotemmiz Can we use a similar approach to deal with disabling animations on android emulator? |
Is this resolved yet ? |
The thing @guyca mentioned was resolved here: https://github.com/wix/react-native-navigation/blob/v2/e2e/init.js Regarding the preStart script, I find it to be a confusing and a bad pattern. If you need something to be initiated or controlled, solve it from inside the test script. |
For example:
The text was updated successfully, but these errors were encountered: