Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setOrientation should rotate device instead of setting orientation on the activity #599

Open
guyca opened this issue Mar 4, 2018 · 3 comments

Comments

@guyca
Copy link

guyca commented Mar 4, 2018

The following code sets orientation on the activity, idealy it would roatate the device.

We're using detox in react-native-navigation v2 and would like to test orientation related use cases. in RNN we handle the activity's orientation using the same android api, setRequestedOrientation and detox interferes with our api.

This can be reproduced by running our e2e suite yarn run test-e2e-android-detox

@rotemmiz
Copy link
Contributor

rotemmiz commented Mar 4, 2018

We'll add a new API, device.rotateDevice(), for Android only, to rotate the device itself, outside of the process.

@d4vidi d4vidi self-assigned this Nov 19, 2021
@d4vidi d4vidi added this to the Q4/2021 Bugathon milestone Nov 19, 2021
@d4vidi d4vidi modified the milestones: Q4/2021 Bugathon, Q1/2022 Bugathon Dec 5, 2021
@d4vidi d4vidi removed this from the Q1/2022 Bugathon milestone May 17, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

@stale stale bot added the 🏚 stale label Jun 18, 2022
@stale
Copy link

stale bot commented Jun 27, 2022

The issue has been closed for inactivity.

@stale stale bot closed this as completed Jun 27, 2022
@noomorph noomorph reopened this Jan 11, 2023
@stale stale bot removed the 🏚 stale label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants