-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CI: add demo-projects-android build #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What is the point of having the demo projects run in CI at all? They just take time and are useless. The main test suit already runs and displays viability. |
|
I'm not saying we should remove them. They are good examples of how to setup an app with Detox. But I don't see the value of running them in CI and blocking builds with them. The test suite is already running anyway, in several RN versions, so that gives enough sanity. The added redundancy in this case adds no redundancy. |
Resolved by @d4vidi . Kudos! |
The demo projects are tested solely in Mac+iOS chain on CI:
https://jenkins-oss.wixpress.com/job/detox-demo-projects-pr/
To achieve parity, we might add a Linux+Android build for demo projects on CI as well.
The text was updated successfully, but these errors were encountered: