Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with types on latest typescript (3.5), New typescript fails with error #212

Closed
LeonFedotov opened this issue Aug 26, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@LeonFedotov
Copy link
Contributor

Pr thats adding a @ts-ignore is in place until we figure this out -> #211
Error:(358, 75) TS2344: Type ‘UnionToIntersection<Value>’ does not satisfy the constraint ‘object’.
cc: @noamr

@LeonFedotov LeonFedotov added the bug Something isn't working label Aug 26, 2019
@LeonFedotov
Copy link
Contributor Author

Maybe @AviVahl can provide some insights.

@AviVahl
Copy link

AviVahl commented Aug 26, 2019

insights:
typescript changed their type handling in the past 2 versions quite a lot. many places that used to default to {} now default to unknown. I guess this caused the error.
I'll try finding the relevant PR.

EDIT: microsoft/TypeScript#30637
there were other related changes to the type checker, but this is probably the root cause.

@LeonFedotov
Copy link
Contributor Author

Great stuff! Thank you @AviVahl, @idok I think we found our issue :)
Cc @noamr

@noamr
Copy link
Contributor

noamr commented Aug 26, 2019

Oh interesting. Yes, I would suggest using {} in Carmi typings instead of object.

@LeonFedotov
Copy link
Contributor Author

LeonFedotov commented Sep 4, 2019

@noamr unfortunately this didn't do the trick. any more ideas? (#222)
cc @idok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants