Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parens for setting precedence #3

Open
withoutboats opened this issue Nov 28, 2015 · 0 comments
Open

Parens for setting precedence #3

withoutboats opened this issue Nov 28, 2015 · 0 comments

Comments

@withoutboats
Copy link
Collaborator

The spec supports paren enclosed sub-expressions, which this library would find invalid.

The correct grammar:

license        ::= SPDX-license | SPDX-license, '+'
license_with   ::= license | license, 'WITH', SPDX-exception | '(', license_expr, ')'
license_joiner ::= 'AND' | 'OR'
license_expr   ::= license_with, (license_joiner, license_with)*

The 1.2.0 version's grammar:

license        ::= SPDX-license | SPDX-license, '+'
license_with   ::= license | license, 'WITH', SPDX-exception
license_joiner ::= 'AND' | 'OR'
license_expr   ::= license_with, (license_joiner, license_with)*
@hobofan hobofan mentioned this issue Jan 14, 2016
Open
@mspiegel mspiegel mentioned this issue May 2, 2016
Closed
@mspiegel mspiegel mentioned this issue May 9, 2016
Closed
@wking wking mentioned this issue Jan 4, 2018
Merged
wking added a commit to wking/cargo that referenced this issue Jan 4, 2018
@wking
src/doc/manifest: Parenthesis not supported in 'license'
c89dd64 
Document [1] where authors can find it.

[1]: ehuss/license-exprs#3
This was referenced Jan 4, 2018
Merged
Closed
wking added a commit to wking/licensee that referenced this issue Jan 9, 2018
@wking
matchers/cargo: Allow SPDX expressions
d570891 
Using a regex that is similar to the one in
lib/licensee/matchers/spdx.rb in allowing spaces and parens.  Parens
aren't currently supported by Cargo's crates.io backing [1,2], but
that's hopefully a temporary limitation.  And Cargo/crates.io already
supports OR forms [3].

Ideally licensee would return the full license expression in these
cases instead of 'other' [4].  But since that conversion is happening
outside the matcher this commit isn't making that any worse (although
it means this test isn't quite a unit test).

[1]: ehuss/license-exprs#3
[2]: rust-lang/cargo@c89dd64
[3]: rust-lang/cargo#4920
[4]: licensee#244
@wking wking mentioned this issue Jan 9, 2018
Merged
wking added a commit to wking/licensee that referenced this issue Jan 9, 2018
@wking
matchers/cargo: Allow SPDX expressions
87cfeb4 
Using a regex that is similar to the one in
lib/licensee/matchers/spdx.rb in allowing spaces and parens.  Parens
aren't currently supported by Cargo's crates.io backing [1,2], but
that's hopefully a temporary limitation.  And Cargo/crates.io already
supports OR forms [3].

Ideally licensee would return the full license expression in these
cases instead of 'other' [4].  But since that conversion is happening
outside the matcher, this commit isn't making that any worse (although
it means this test isn't quite a unit test).

[1]: ehuss/license-exprs#3
[2]: rust-lang/cargo@c89dd64
[3]: rust-lang/cargo#4920
[4]: licensee#244
@bossmc bossmc mentioned this issue May 28, 2019
Closed
@sunfishcode sunfishcode mentioned this issue Aug 29, 2019
Merged
sunfishcode added a commit to bytecodealliance/wasi-rs that referenced this issue Aug 29, 2019
@sunfishcode
Remove parens from license expression.
d79461a 
license-exprs doesn't yet support parens:

ehuss/license-exprs#3

so remove them for now. The parens were redundant by the license expression
precedence rules in

https://spdx.org/spdx-specification-21-web-version.
@carols10cents carols10cents mentioned this issue Jun 23, 2020
Closed
@johnbatty johnbatty mentioned this issue Jun 23, 2021
Merged
@hsivonen hsivonen mentioned this issue Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@withoutboats