Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PUT route returns null source parameter #28

Closed
JoshBrodieNZ opened this issue May 4, 2017 · 0 comments
Closed

New PUT route returns null source parameter #28

JoshBrodieNZ opened this issue May 4, 2017 · 0 comments

Comments

@JoshBrodieNZ
Copy link

JoshBrodieNZ commented May 4, 2017

Hey team,

Started to put together a PR and realised I couldn't determine what the intended behaviour is here.

I note that the API's new update_parser takes only a target argument. However, the PUT route is marshalled with resource_fields which contains a source argument also. As a result, the PUT request is responded to with a null source, such that submitting {"target":"127.0.0.1"} to /api/routes/test.com results in a response containing {"source": null,"target": "127.0.0.1"}.

Should this return value draw the source from a valid location, or should source be omitted from the return value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant