Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Fig with Windows #35

Open
brendanfalk opened this issue Feb 19, 2021 · 36 comments
Open

Integrate Fig with Windows #35

brendanfalk opened this issue Feb 19, 2021 · 36 comments
Labels
type:integration-request Request for an intergration with an existing tool

Comments

@brendanfalk
Copy link
Member

brendanfalk commented Feb 19, 2021

Fig currently works on macOS only. We will build a port that integrates with Windows soon.

Please subscribe to this issue to get an update when Fig's autocomplete integration with the Window is ready 😄

@brendanfalk brendanfalk mentioned this issue Mar 6, 2021
@brendanfalk brendanfalk added the type:integration-request Request for an intergration with an existing tool label Apr 8, 2021
@brendanfalk brendanfalk changed the title [INTEGRATION] Integrate Fig with Windows Integrate Fig with Windows Apr 8, 2021
@SJanJan
Copy link

SJanJan commented Sep 30, 2021

super work

@jacobra19
Copy link

Commenting to get updates - it's really useful, I hope to see a Windows release soon!

you could just click on the 'watch' button at the top

@felix-berlin
Copy link

I can hardly wait!

@ayr-ton
Copy link

ayr-ton commented Dec 15, 2021

Maybe the best approach for this one is trying to write an app like https://github.com/microsoft/terminal/tree/main/samples that consumes the new Windows Console APIs.
Support for zsh/bash/fish first via WSL and Windows Console APIs could be a good MVP. Powershell in MVP 2.

@mschrage
Copy link
Member

mschrage commented Jan 19, 2022

Hey everyone! Thank you for your patience. We are super excited about bringing Fig to Windows, but there is lots of work to do before this is possible.

There are at least 7 core functions that need to be built out in order for us to release autocomplete to Windows.

  1. We need to be able to determine the location of the cursor in a 3rd party app.

This seems possible using Microsoft Active Accessibility APIs.

Other Resources

  1. We need to be able to determine what you've typed in the terminal

This means porting our pseudoterminal layer (figterm) to Window. We need to do some research to understand how this should work on a non-UNIX system.
See ConPTY

  1. We need to do IPC between our CLI tools and our GUI app. On macOS (and Linux) we use UNIX domain sockets. I am not sure about the equivalent on Windows.

  2. We need to be able to position a 'floating' window overlay on top of 3rd party applications.

  3. We need intercept certain keystrokes to prevent them from being handled by the shell. This can be implemented at the OS level or potentially at the pseudoterminal level.

  4. We need to port over the Fig.js API to Windows. This is the subsystem that links our TypeScript autocomplete engine with native OS functionality.

  5. We need to install our shell integrations. This entails research & experimentation with how shells work on Windows. eg. What is the difference between Cygwin, MSYS/MinGW, git bash and WSL? Which should we support? Where are bashrc and bash_profile equivalents located?

See "How can I use a bash-like shell on Windows" for more details.
Also: "Launching a daemon from WSL"

If you have any insight on how to solve these challenges, please comment below or join our #cross-platform channel on Discord. ❤️

@levrik
Copy link

levrik commented Jan 20, 2022

@mschrage
I think UNIX domain sockets are available on Windows: https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/
I don't know if the implementation is more complete nowadays or if it's still lacking the missing features mentioned in the linked article. I also don't know which features you need so the implementation might be enough for your usecase.

@BasixKOR
Copy link

I think winpty could be a great starting point for pseudo-console implementation. It is known to work well with other UNIX-like software as well.

@ntindle
Copy link

ntindle commented Jan 21, 2022

Regarding #1 in the list above, it may be worthwhile to add native support to windows terminal rather than have it be an accessibility hack

@mschrage
Copy link
Member

mschrage commented Jan 25, 2022

@levrik I didn't know about that Windows had added support for AF_UNIX socket networking. That's awesome.

@BasixKOR I will look into winpty! Our pseudoterminal is written in Rust, so we'll need to figure the right approach / library.

@ntindle does Windows Terminal have support for GUI plugins like Fig? If you have any links to documentation on this or thoughts on how to implement native support, please let me know.

@digeomel
Copy link

digeomel commented Jan 28, 2022

I understand that Windows terminal support is not done yet, but I'm a bit confused about vscode on Windows, because your README writes that it works on vscode terminal. I assume it only works on vscode terminal on MacOS, right?

@RyKilleen
Copy link

Here's the master feature list for extensions on Windows Terminal.

microsoft/terminal#4000

As far as I can tell, the command palette is fully extensible but doesn't provide the sort of inline support you're probably looking for. They seem very open to feature requests though

@pcgeek86
Copy link

The "Hyper" terminal from Vercel runs on Windows as well as MacOS. It'd be great to see Fig work with Hyper on Windows 11, at least, even if Windows Terminal integration doesn't work yet.

@mschrage
Copy link
Member

@digeomel that's exactly right. Fig supports VSCode, but only on macOS.

@pcgeek86 Same thing for Hyper.

@mschrage
Copy link
Member

mschrage commented Feb 4, 2022

What is the unix-like environment you use on Windows most often?

I'm assuming WSL, but I could be completely wrong.

@jasonwashburn
Copy link

jasonwashburn commented Feb 4, 2022 via email

@TheOnlyTails
Copy link

I actually almost never use WSL, I use Git Bash (via Windows Terminal), with Zsh installed on top of it.

@kidsamort
Copy link

I also always use Git Bash

@MystPi
Copy link

MystPi commented Feb 21, 2022

Honestly I mostly just use Powershell; not WSL or Git Bash.

@Lioness100
Copy link

I always use git bash :)

@ionut-botizan
Copy link

Terminal: Windows Terminal
Default Shell: Powershell Core (Not sure if it matters, but a heads up: there's the default, older version of Powershell and there's Powershell Core, which is the better, open source version, that also runs on Linux and MacOS)
*Nix env: WSL Ubuntu with Bash/Fish (but I rarely need it)

-- Used Cygwin in the past (feels like a lifetime ago)
-- Never understood why Git Bash even exists

@sergiubacioiu
Copy link

Please consider adding support for Tabby on Windows.
https://tabby.sh/

@resonancedesigns
Copy link

WSL when using VS Code terminal, Git Bash otherwise.

@syedfaizan
Copy link

I use Cmder, works really well.

@joshuajeschek
Copy link

I also use Tabby, which is written in TypeScript and allows for plugins - a Tabby Plugin would be fantastic!

@hxse
Copy link

hxse commented Mar 10, 2022

Hope to support alacritty.

@mschrage
Copy link
Member

Some exciting progress to share!

windows_fig_demo.mp4

We've located the caret position, can determine what text has been typed, and got IPC working on Windows. 🥳 There is still lots to do, but some of the key technical challenges have been solved!

We likely will focus on WSL at first and then branch out to support other environments, like git bash and Powershell.

@levrik
Copy link

levrik commented Mar 23, 2022

@mschrage Wow. Is Fig written in Rust? This r#type looks very familiar. Also seeing a .cargo-lock file in the directory.

@florian-lefebvre
Copy link

@levrik Looking at the executable icon, it's a tauri app (https://github.com/tauri-apps/tauri) so yes it's built with Rust.

@mschrage
Copy link
Member

Good eye @florian-lefebvre!

@levrik To answer your question: yes, we use Rust! 🦀

@levrik
Copy link

levrik commented Mar 24, 2022

@mschrage And few hours later I received your newsletter mentioning usage of Rust for at least your CLI 😅

@MichaelBell
Copy link

Fig looks very interesting, would be great to see this working with PuTTY on Windows too.

@haltcase
Copy link

haltcase commented Apr 1, 2022

Could we please keep the comments here limited to the issue and move other comments to a discussion? I'd like to stay connected with progress to Fig coming to Windows, but notifications like these last few can be very noisy.

@withfig withfig deleted a comment from ntindle Apr 1, 2022
@withfig withfig deleted a comment from DefinitelyADev Apr 1, 2022
@withfig withfig deleted a comment from incubusnb Apr 1, 2022
@sasial-dev
Copy link

Could we lock this issue to the fig team only (for updates) and then create a discussion post for this issue for discussion on it?

@mschrage
Copy link
Member

mschrage commented Apr 2, 2022

Good idea @sasial-dev and thanks for moving the conversation in a more constructive direction @haltcase.

I’ll lock this issue for now.

@withfig withfig locked and limited conversation to collaborators Apr 2, 2022
@mschrage
Copy link
Member

The team just hit another milestone!

windows_demo.mp4

This is a really rough version of autocomplete running on Windows. Still more work to be done, but we're getting there! 🙌

@grant0417 grant0417 pinned this issue Jun 22, 2022
@sullivan-sean
Copy link

We're rolling out a closed alpha/prototype of Fig on Windows to a few users in the next week or so -- if you're on Windows and interested in getting early access, fill out the typeform here: https://withfig.typeform.com/to/n58Z7ciy

@grant0417 grant0417 unpinned this issue Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:integration-request Request for an intergration with an existing tool
Projects
None yet
Development

No branches or pull requests