Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): Update multiple files with EC markers #1114

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 23, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

This PR updates the french version of the following files with the changes of #1102:

  • guides/components.mdx
  • guides/css-and-tailwind.mdx
  • guides/customization.mdx
  • guides/sidebar.mdx
  • reference/frontmatter.md
  • reference/overrides.md

Copy link

changeset-bot bot commented Nov 23, 2023

⚠️ No Changeset found

Latest commit: 8cb9432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Nov 23, 2023 7:05pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 23, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Noting that often you would be free to choose a translated filename if you wanted, e.g. exemple.md (just have to make sure it agrees between text and filename if it’s referenced in text), but will leave that choice to you.

@HiDeoo
Copy link
Member Author

HiDeoo commented Nov 23, 2023

Noting that often you would be free to choose a translated filename if you wanted, e.g. exemple.md (just have to make sure it agrees between text and filename if it’s referenced in text), but will leave that choice to you.

Oh, this is a great idea, I never thought of that. Stealing your idea and adding it to my personal todos and I think I'll make a global pass at this in a dedicated PR 🙌

@HiDeoo HiDeoo merged commit c537fe1 into withastro:main Nov 23, 2023
7 checks passed
@HiDeoo HiDeoo deleted the hd-i18n-fr-0-13-0-ec-markers branch November 23, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants