Add tests for optional props on Svelte components (#344)

* Add tests for Svelte optional props

* Fix expected message

* Update to latest Svelte integration

Author: Princesseuh

packages/language-server/package.json

@@ -31,8 +31,8 @@
     "vscode-uri": "^3.0.3"
   },
   "devDependencies": {
-    "@astrojs/svelte": "^0.2.1",
-    "@astrojs/vue": "^0.2.1",
+    "@astrojs/svelte": "^0.5.0",
+    "@astrojs/vue": "^0.5.0",
     "@types/chai": "^4.3.0",
     "@types/mocha": "^9.1.0",
     "@types/sinon": "^10.0.11",

packages/language-server/test/plugins/typescript/features/DiagnosticsProvider.test.ts

@@ -112,6 +112,24 @@ describe('TypeScript Plugin#DiagnosticsProvider', () => {
 		]);
 	});
 
+	it('properly support optional props on Svelte components', async () => {
+		const { provider, document } = setup('svelteOptional.astro');
+
+		const diagnostics = await provider.getDiagnostics(document);
+
+		expect(diagnostics).to.deep.equal([
+			{
+				code: 2322,
+				message:
+					"Type '{}' is not assignable to type 'IntrinsicAttributes & { notOptional: any; optional?: string; }'.\n  Property 'notOptional' is missing in type '{}' but required in type '{ notOptional: any; optional?: string; }'.",
+				range: Range.create(4, 1, 4, 20),
+				severity: DiagnosticSeverity.Error,
+				source: 'ts',
+				tags: [],
+			},
+		]);
+	});
+
 	it('provide diagnostics for invalid framework components', async () => {
 		const { provider, document } = setup('frameworkComponentError.astro');
 

packages/language-server/test/plugins/typescript/features/HoverProvider.test.ts

@@ -67,7 +67,7 @@ describe('TypeScript Plugin#HoverProvider', () => {
 
 		expect(hoverInfo).to.deep.equal(<Hover>{
 			contents:
-				'```typescript\n(alias) function Sveltecomment(_props: typeof Props): any\nimport Sveltecomment\n```\n---\nMy super Svelte component!',
+				'```typescript\n(alias) function Sveltecomment(_props: typeof Component.props): any\nimport Sveltecomment\n```\n---\nMy super Svelte component!',
 			range: Range.create(4, 1, 4, 14),
 		});
 	});

packages/language-server/test/plugins/typescript/fixtures/diagnostics/SvelteOptionalProps.svelte

@@ -0,0 +1,4 @@
+<script>
+	export const optional = "Hey"
+	export let notOptional
+</script>

packages/language-server/test/plugins/typescript/fixtures/diagnostics/svelteOptional.astro

@@ -0,0 +1,5 @@
+---
+import SvelteOptionalProps from "./SvelteOptionalProps.svelte"
+---
+
+<SvelteOptionalProps></SvelteOptionalProps>