lastmod of SitemapItem object is not String type

[tkskto]

📚 Subject area/topic

Integrations

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/ja/guides/integrations-guide/sitemap/#serialize

📋 Description of content that is out-of-date or incorrect

The documentation states that lastmod is:

lastmod (ISO formatted date, String type)

However, upon inspecting the implementation code, lastmod is being handled as a Date type.

However since this Date type is based on Universal Time (UTC), it's not possible to directly specify the lastmod in a specific timezone (e.g., Japan Standard Time (JST)) using a string representation. It is my view that the implementation could be changed to consider the possibility of allowing the String type to be specified.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

[sarah11918]

Hi! You're right that looking at the code lastmod does appear to be misidentified. Would you like to make a PR to update that? I think the example it's used in directly following seems correct, since it is defining a new Date, but would appreciate you looking at that too to figure out whether an update is also needed to the code sample.

As for considering changing the implementation, that's not something that docs can do. All we can do is document exactly how it does currently work. In order for your suggestion to be seen, you could file an issue on the main withastro/astro repo mentioning that this current behaviour is limiting. You can also mention this in our #feedback-ideas channel in the Astro Discord! Unfortunately, all we can do in the docs repo is correct the errors in the current documentation.

So I'll add help wanted on this issue and would welcome a PR to update this entry in docs!

[tkskto]

Okay, I understand. I will suggest to the main Astro repository. The content that needs to be addressed in this issue might change depending on it. Thanks.

[sarah11918]

Closed with 10595

[tkskto]

@sarah11918

As ArmandPhilippot mentioned, it comes from the sitemap package. I appreciate your time. 🙏

I also closed withastro/astro issue.