Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL to RSSOptions.site type #7964

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add URL to RSSOptions.site type #7964

merged 1 commit into from
Aug 7, 2023

Conversation

DerTimonius
Copy link
Contributor

Changes

  • This PR adds the URL type to RSSOptions.site
  • site was only of type string before and lead to TS errors
  • Closes RSS: wrong site type #7951
  • Ran pnpm exec changeset

Testing

  • Did manual testing in TS Playground to check for the best option (wanted to use zod instead of URL directly, but did not really work)
  • Existing tests still run as expected

Docs

  • No changes in the docs necessary

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 83f3f22

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy bluwy merged commit 51028f8 into withastro:main Aug 7, 2023
@bluwy
Copy link
Member

bluwy commented Aug 7, 2023

Thanks!

@astrobot-houston astrobot-houston mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSS: wrong site type
2 participants
@DerTimonius @bluwy