refactor(create-astro): migrate tests to typescript

packages/astro-rss/tsconfig.test.json

@@ -3,7 +3,6 @@
   "include": ["test/**/*.ts"],
   "exclude": ["test/fixtures/**"],
   "compilerOptions": {
-    "noEmit": true,
     "allowJs": true,
     "noUnusedLocals": false,
     "noUnusedParameters": false,

packages/create-astro/package.json

@@ -22,7 +22,8 @@
     "build": "astro-scripts build \"src/index.ts\" --bundle && tsc",
     "build:ci": "astro-scripts build \"src/index.ts\" --bundle",
     "dev": "astro-scripts dev \"src/**/*.ts\"",
-    "test": "astro-scripts test \"test/**/*.test.js\""
+    "test": "astro-scripts test \"test/**/*.test.ts\"",
+    "typecheck:tests": "tsc --build tsconfig.test.json"
   },
   "files": [
     "dist",

packages/create-astro/test/context.test.js → packages/create-astro/test/context.test.ts

@@ -73,14 +73,20 @@ describe('context', () => {
 	});
 
 	it('--add with --no-install conflicts', async () => {
-		const exitCode = await new Promise((resolve) => {
-			const originalExit = process.exit;
-			process.exit = (code) => {
-				process.exit = originalExit;
-				resolve(code);
-			};
-			getContext(['--add', 'cloudflare', '--no-install']);
-		});
+		const originalExit = process.exit;
+		let exitCode: number | string | null | undefined;
+		const patchedExit: typeof originalExit = (code) => {
+			exitCode = code;
+			throw code;
+		};
+		process.exit = patchedExit;
+		try {
+			await getContext(['--add', 'cloudflare', '--no-install']);
+		} catch {
+			// expected: patchedExit throws to unwind getContext
+		} finally {
+			process.exit = originalExit;
+		}
 		assert.equal(exitCode, 1);
 	});
 });

packages/create-astro/test/dependencies.test.js → packages/create-astro/test/dependencies.test.ts

@@ -1,18 +1,19 @@
 import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 import { dependencies } from '../dist/index.js';
-import { setup } from './utils.js';
+import { type DependenciesContext, mockPrompt, setup } from './utils.ts';
 
 describe('dependencies', () => {
 	const fixture = setup();
 
 	it('--yes', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			yes: true,
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: true }),
+			prompt: mockPrompt({ deps: true }),
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -21,13 +22,14 @@ describe('dependencies', () => {
 	});
 
 	it('--yes with third-party template warns', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			yes: true,
 			template: 'github:someone/starter',
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: true }),
+			prompt: mockPrompt({ deps: true }),
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -36,13 +38,14 @@ describe('dependencies', () => {
 	});
 
 	it('starlight templates do not warn', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			yes: true,
 			template: 'starlight/tailwind',
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: true }),
+			prompt: mockPrompt({ deps: true }),
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -51,13 +54,14 @@ describe('dependencies', () => {
 	});
 
 	it('starlight-prefixed third-party templates warn', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			yes: true,
 			template: 'starlightevil/foo',
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: true }),
+			prompt: mockPrompt({ deps: true }),
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -66,13 +70,14 @@ describe('dependencies', () => {
 	});
 
 	it('warns without --yes when install is enabled', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			install: true,
 			template: 'github:someone/starter',
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: true }),
+			prompt: mockPrompt({ deps: true }),
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -81,12 +86,13 @@ describe('dependencies', () => {
 	});
 
 	it('prompt yes', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: true }),
+			prompt: mockPrompt({ deps: true }),
 			install: undefined,
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -96,12 +102,13 @@ describe('dependencies', () => {
 	});
 
 	it('prompt no', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: false }),
+			prompt: mockPrompt({ deps: false }),
 			install: undefined,
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -111,25 +118,27 @@ describe('dependencies', () => {
 	});
 
 	it('--install', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			install: true,
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: false }),
+			prompt: mockPrompt({ deps: false }),
+			tasks: [],
 		};
 		await dependencies(context);
 		assert.ok(fixture.hasMessage('Skipping dependency installation'));
 		assert.equal(context.install, true);
 	});
 
 	it('--no-install ', async () => {
-		const context = {
+		const context: DependenciesContext = {
 			cwd: '',
 			install: false,
 			packageManager: 'npm',
 			dryRun: true,
-			prompt: () => ({ deps: false }),
+			prompt: mockPrompt({ deps: false }),
+			tasks: [],
 		};
 
 		await dependencies(context);
@@ -140,17 +149,20 @@ describe('dependencies', () => {
 
 	describe('--add', async () => {
 		it('fails for non-supported integration', async () => {
-			let context = {
+			let context: DependenciesContext = {
 				cwd: '',
 				add: ['foo '],
 				dryRun: true,
-				prompt: () => ({ deps: false }),
+				prompt: mockPrompt({ deps: false }),
+				packageManager: 'npm',
+				tasks: [],
 			};
 
 			try {
 				await dependencies(context);
 				assert.fail('The function should throw an error');
 			} catch (error) {
+				assert.ok(error instanceof Error);
 				assert.ok(
 					error.message.includes('Invalid package name "foo "'),
 					`Expected error about invalid package name, got: ${error.message}`,
@@ -160,13 +172,16 @@ describe('dependencies', () => {
 				cwd: '',
 				add: ['react', 'bar lorem'],
 				dryRun: true,
-				prompt: () => ({ deps: false }),
+				prompt: mockPrompt({ deps: false }),
+				packageManager: 'npm',
+				tasks: [],
 			};
 
 			try {
 				await dependencies(context);
 				assert.fail('The function should throw an error');
 			} catch (error) {
+				assert.ok(error instanceof Error);
 				assert.ok(
 					error.message.includes('Invalid package name "bar lorem"'),
 					`Expected error about invalid package name, got: ${error.message}`,

packages/create-astro/test/git.test.js → packages/create-astro/test/git.test.ts

@@ -4,26 +4,41 @@ import { mkdir, writeFile } from 'node:fs/promises';
 import { after, before, describe, it } from 'node:test';
 
 import { git } from '../dist/index.js';
-import { setup } from './utils.js';
+import { type GitContext, mockPrompt, setup } from './utils.ts';
 
 describe('git', () => {
 	const fixture = setup();
 
 	it('none', async () => {
-		const context = { cwd: '', dryRun: true, prompt: () => ({ git: false }) };
+		const context: GitContext = {
+			cwd: '',
+			dryRun: true,
+			prompt: mockPrompt({ git: false }),
+			tasks: [],
+		};
 		await git(context);
 
 		assert.ok(fixture.hasMessage('Skipping Git initialization'));
 	});
 
 	it('yes (--dry-run)', async () => {
-		const context = { cwd: '', dryRun: true, prompt: () => ({ git: true }) };
+		const context: GitContext = {
+			cwd: '',
+			dryRun: true,
+			prompt: mockPrompt({ git: true }),
+			tasks: [],
+		};
 		await git(context);
 		assert.ok(fixture.hasMessage('Skipping Git initialization'));
 	});
 
 	it('no (--dry-run)', async () => {
-		const context = { cwd: '', dryRun: true, prompt: () => ({ git: false }) };
+		const context: GitContext = {
+			cwd: '',
+			dryRun: true,
+			prompt: mockPrompt({ git: false }),
+			tasks: [],
+		};
 		await git(context);
 
 		assert.ok(fixture.hasMessage('Skipping Git initialization'));
@@ -40,11 +55,12 @@ describe('git initialized', () => {
 	});
 
 	it('already initialized', async () => {
-		const context = {
+		const context: GitContext = {
 			git: true,
 			cwd: './test/fixtures/not-empty',
 			dryRun: false,
-			prompt: () => ({ git: false }),
+			prompt: mockPrompt({ git: false }),
+			tasks: [],
 		};
 		await git(context);