Skip to content

refactor: remove PRERENDER env variable in tests #16391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 1 commit into from
Apr 20, 2026
Merged

refactor: remove PRERENDER env variable in tests #16391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/integrations/node/test/node-middleware-listener-cleanup.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ describe('Node middleware socket listener cleanup', () => {
let server;

before(async () => {
process.env.PRERENDER = true;
fixture = await loadFixture({
root: './fixtures/node-middleware/',
output: 'static',
Expand All @@ -36,7 +35,6 @@ describe('Node middleware socket listener cleanup', () => {
after(async () => {
server.close();
await fixture.clean();
delete process.env.PRERENDER;
});

it('should not leak socket listeners when serving static files', async () => {
Expand Down
9 changes: 0 additions & 9 deletions packages/integrations/node/test/node-middleware.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ describe('behavior from middleware, standalone', () => {
let server;

before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
root: './fixtures/node-middleware/',
output: 'server',
Expand All @@ -35,8 +34,6 @@ describe('behavior from middleware, standalone', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

describe('404', async () => {
Expand All @@ -60,7 +57,6 @@ describe('behavior from middleware, middleware with express', () => {
let server;

before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
root: './fixtures/node-middleware/',
output: 'server',
Expand All @@ -76,8 +72,6 @@ describe('behavior from middleware, middleware with express', () => {
after(async () => {
server.close();
await fixture.clean();

delete process.env.PRERENDER;
});

it('should render the endpoint', async () => {
Expand Down Expand Up @@ -145,7 +139,6 @@ describe('behavior from middleware, middleware with fastify', () => {
let server;

before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
root: './fixtures/node-middleware/',
output: 'server',
Expand All @@ -169,8 +162,6 @@ describe('behavior from middleware, middleware with fastify', () => {
after(async () => {
server.close();
await fixture.clean();

delete process.env.PRERENDER;
});

it('should render the endpoint', async () => {
Expand Down
10 changes: 0 additions & 10 deletions packages/integrations/node/test/prerender-404-500.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ describe('Prerender 404', () => {

describe('With base', async () => {
before(async () => {
process.env.PRERENDER = true;

fixture = await loadFixture({
// inconsequential config that differs between tests
// to bust cache and prevent modules and their state
Expand All @@ -38,7 +36,6 @@ describe('Prerender 404', () => {
after(async () => {
await server.stop();
await fixture.clean();
process.env.PRERENDER = undefined;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -102,8 +99,6 @@ describe('Prerender 404', () => {

describe('Without base', async () => {
before(async () => {
process.env.PRERENDER = true;

fixture = await loadFixture({
// inconsequential config that differs between tests
// to bust cache and prevent modules and their state
Expand All @@ -124,7 +119,6 @@ describe('Prerender 404', () => {
after(async () => {
await server.stop();
await fixture.clean();
process.env.PRERENDER = undefined;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -167,7 +161,6 @@ describe('Hybrid 404', () => {

describe('With base', async () => {
before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
// inconsequential config that differs between tests
// to bust cache and prevent modules and their state
Expand All @@ -189,7 +182,6 @@ describe('Hybrid 404', () => {
after(async () => {
await server.stop();
await fixture.clean();
process.env.PRERENDER = undefined;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -226,7 +218,6 @@ describe('Hybrid 404', () => {

describe('Without base', async () => {
before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
// inconsequential config that differs between tests
// to bust cache and prevent modules and their state
Expand All @@ -247,7 +238,6 @@ describe('Hybrid 404', () => {
after(async () => {
await server.stop();
await fixture.clean();
process.env.PRERENDER = undefined;
});

it('Can render SSR route', async () => {
Expand Down
25 changes: 0 additions & 25 deletions packages/integrations/node/test/prerender.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ describe('Prerendering', () => {

describe('With base', async () => {
before(async () => {
process.env.PRERENDER = true;

fixture = await loadFixture({
base: '/some-base',
root: './fixtures/prerender/',
Expand All @@ -34,8 +32,6 @@ describe('Prerendering', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -103,8 +99,6 @@ describe('Prerendering', () => {

describe('Without base', async () => {
before(async () => {
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/prerender/',
output: 'server',
Expand All @@ -121,8 +115,6 @@ describe('Prerendering', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -180,7 +172,6 @@ describe('Prerendering', () => {

describe('Via integration', () => {
before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
root: './fixtures/prerender/',
output: 'server',
Expand Down Expand Up @@ -209,8 +200,6 @@ describe('Prerendering', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand All @@ -237,8 +226,6 @@ describe('Prerendering', () => {
let devServer;

before(async () => {
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/prerender/',
output: 'server',
Expand All @@ -250,8 +237,6 @@ describe('Prerendering', () => {

after(async () => {
await devServer.stop();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -281,7 +266,6 @@ describe('Hybrid rendering', () => {

describe('With base', () => {
before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
base: '/some-base',
root: './fixtures/prerender/',
Expand All @@ -299,8 +283,6 @@ describe('Hybrid rendering', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -367,7 +349,6 @@ describe('Hybrid rendering', () => {

describe('Without base', () => {
before(async () => {
process.env.PRERENDER = false;
fixture = await loadFixture({
root: './fixtures/prerender/',
output: 'static',
Expand All @@ -384,8 +365,6 @@ describe('Hybrid rendering', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand Down Expand Up @@ -443,8 +422,6 @@ describe('Hybrid rendering', () => {

describe('Shared modules', () => {
before(async () => {
process.env.PRERENDER = false;

fixture = await loadFixture({
root: './fixtures/prerender/',
output: 'static',
Expand All @@ -461,8 +438,6 @@ describe('Hybrid rendering', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render SSR route', async () => {
Expand Down
18 changes: 0 additions & 18 deletions packages/integrations/node/test/trailing-slash.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ describe('Trailing slash', () => {
describe('With base', async () => {
before(async () => {
process.env.ASTRO_NODE_AUTOSTART = 'disabled';
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/trailing-slash/',
Expand All @@ -36,8 +35,6 @@ describe('Trailing slash', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render prerendered base route', async () => {
Expand Down Expand Up @@ -96,7 +93,6 @@ describe('Trailing slash', () => {
describe('Without base', async () => {
before(async () => {
process.env.ASTRO_NODE_AUTOSTART = 'disabled';
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/trailing-slash/',
Expand All @@ -115,8 +111,6 @@ describe('Trailing slash', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render prerendered base route', async () => {
Expand Down Expand Up @@ -214,7 +208,6 @@ describe('Trailing slash', () => {
describe('With base', async () => {
before(async () => {
process.env.ASTRO_NODE_AUTOSTART = 'disabled';
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/trailing-slash/',
Expand All @@ -234,8 +227,6 @@ describe('Trailing slash', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render prerendered base route', async () => {
Expand Down Expand Up @@ -276,7 +267,6 @@ describe('Trailing slash', () => {
describe('Without base', async () => {
before(async () => {
process.env.ASTRO_NODE_AUTOSTART = 'disabled';
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/trailing-slash/',
Expand All @@ -295,8 +285,6 @@ describe('Trailing slash', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render prerendered base route', async () => {
Expand Down Expand Up @@ -339,7 +327,6 @@ describe('Trailing slash', () => {
describe('With base', async () => {
before(async () => {
process.env.ASTRO_NODE_AUTOSTART = 'disabled';
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/trailing-slash/',
Expand All @@ -359,8 +346,6 @@ describe('Trailing slash', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render prerendered base route', async () => {
Expand Down Expand Up @@ -419,7 +404,6 @@ describe('Trailing slash', () => {
describe('Without base', async () => {
before(async () => {
process.env.ASTRO_NODE_AUTOSTART = 'disabled';
process.env.PRERENDER = true;

fixture = await loadFixture({
root: './fixtures/trailing-slash/',
Expand All @@ -438,8 +422,6 @@ describe('Trailing slash', () => {
after(async () => {
await server.stop();
await fixture.clean();

delete process.env.PRERENDER;
});

it('Can render prerendered base route', async () => {
Expand Down
1 change: 0 additions & 1 deletion packages/integrations/vercel/test/path-override-security.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ describe('Vercel serverless path override security', () => {
let fixture: Fixture;

before(async () => {
process.env.PRERENDER = 'true';
fixture = await loadFixture({
root: './fixtures/serverless-with-dynamic-routes/',
output: 'server',
Expand Down
2 changes: 0 additions & 2 deletions packages/integrations/vercel/test/serverless-prerender.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ describe('Serverless prerender', () => {
let fixture: Fixture;

before(async () => {
process.env.PRERENDER = 'true';
fixture = await loadFixture({
root: './fixtures/serverless-prerender/',
});
Expand Down Expand Up @@ -43,7 +42,6 @@ describe('Serverless hybrid rendering', () => {
let fixture: Fixture;

before(async () => {
process.env.PRERENDER = 'true';
fixture = await loadFixture({
root: './fixtures/serverless-prerender/',
output: 'static',
Expand Down
1 change: 0 additions & 1 deletion packages/integrations/vercel/test/serverless-with-dynamic-routes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ describe('Serverless with dynamic routes', () => {
let fixture: Fixture;

before(async () => {
process.env.PRERENDER = 'true';
fixture = await loadFixture({
root: './fixtures/serverless-with-dynamic-routes/',
output: 'server',
Expand Down
Loading