refactor(upgrade): migrate tests to typescript

packages/upgrade/package.json

@@ -20,7 +20,8 @@
     "build": "astro-scripts build \"src/index.ts\" --bundle && tsc",
     "build:ci": "astro-scripts build \"src/index.ts\" --bundle",
     "dev": "astro-scripts dev \"src/**/*.ts\"",
-    "test": "astro-scripts test \"test/**/*.test.js\""
+    "test": "astro-scripts test \"test/**/*.test.ts\"",
+    "typecheck:tests": "tsc -p tsconfig.test.json"
   },
   "files": [
     "dist",

packages/upgrade/test/install.test.js → packages/upgrade/test/install.test.ts

@@ -3,7 +3,7 @@ import { tmpdir } from 'node:os';
 import { describe, it, mock } from 'node:test';
 import { pathToFileURL } from 'node:url';
 import { install } from '../dist/index.js';
-import { setup } from './utils.js';
+import { setup, type ShellFunction } from './utils.ts';
 
 const tmpUrl = pathToFileURL(tmpdir());
 
@@ -70,7 +70,7 @@ describe('install', () => {
 				prompted = true;
 				return { proceed: false };
 			},
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -100,7 +100,7 @@ describe('install', () => {
 				prompted = true;
 				return { proceed: true };
 			},
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -130,7 +130,7 @@ describe('install', () => {
 				prompted = true;
 				return { proceed: true };
 			},
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -172,7 +172,7 @@ describe('install', () => {
 				prompted = true;
 				return { proceed: true };
 			},
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -215,7 +215,7 @@ describe('install', () => {
 	});
 
 	it('npm peer dependency error retry with legacy-peer-deps', async () => {
-		const mockShell = mock.fn(async () => {
+		const mockShell = mock.fn<ShellFunction>(async () => {
 			if (mockShell.mock.callCount() === 0) {
 				// First call fails with peer dependency error
 				throw new Error('npm ERR! peer dependencies conflict');
@@ -230,7 +230,7 @@ describe('install', () => {
 			dryRun: false,
 			cwd: tmpUrl,
 			packageManager: { name: 'npm', agent: 'npm' },
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -259,7 +259,7 @@ describe('install', () => {
 	});
 
 	it('npm non-peer dependency error does not retry', async () => {
-		const mockShell = mock.fn(async () => {
+		const mockShell = mock.fn<ShellFunction>(async () => {
 			throw new Error('npm ERR! some other error');
 		});
 
@@ -269,7 +269,7 @@ describe('install', () => {
 			dryRun: false,
 			cwd: tmpUrl,
 			packageManager: { name: 'npm', agent: 'npm' },
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -290,7 +290,7 @@ describe('install', () => {
 	});
 
 	it('npm peer dependency error retry fails on second attempt', async () => {
-		const mockShell = mock.fn(async () => {
+		const mockShell = mock.fn<ShellFunction>(async () => {
 			// Both calls fail with peer dependency errors
 			throw new Error('npm ERR! peer dependencies conflict');
 		});
@@ -301,7 +301,7 @@ describe('install', () => {
 			dryRun: false,
 			cwd: tmpUrl,
 			packageManager: { name: 'npm', agent: 'npm' },
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [
@@ -331,7 +331,7 @@ describe('install', () => {
 	});
 
 	it('pnpm peer dependency error does not retry', async () => {
-		const mockShell = mock.fn(async () => {
+		const mockShell = mock.fn<ShellFunction>(async () => {
 			throw new Error('pnpm ERR! peer dependencies conflict');
 		});
 
@@ -341,7 +341,7 @@ describe('install', () => {
 			dryRun: false,
 			cwd: tmpUrl,
 			packageManager: { name: 'pnpm', agent: 'pnpm' },
-			exit: (code) => {
+			exit: (code: number) => {
 				exitCode = code;
 			},
 			packages: [

packages/upgrade/test/utils.js → packages/upgrade/test/utils.ts

@@ -2,12 +2,21 @@ import { before, beforeEach } from 'node:test';
 import { stripVTControlCharacters } from 'node:util';
 import { setStdout } from '../dist/index.js';
 
+export type ShellFunction = (
+	command: string,
+	flags: string[],
+) => Promise<{
+	stdout: string;
+	stderr: string;
+	exitCode: number;
+}>;
+
 export function setup() {
-	const ctx = { messages: [] };
+	const ctx: { messages: string[] } = { messages: [] };
 	before(() => {
 		setStdout(
 			Object.assign({}, process.stdout, {
-				write(buf) {
+				write(buf: string | Uint8Array) {
 					ctx.messages.push(stripVTControlCharacters(String(buf)).trim());
 					return true;
 				},
@@ -25,7 +34,7 @@ export function setup() {
 		length() {
 			return ctx.messages.length;
 		},
-		hasMessage(content) {
+		hasMessage(content: string) {
 			return !!ctx.messages.find((msg) => msg.includes(content));
 		},
 	};

packages/upgrade/tsconfig.test.json

@@ -0,0 +1,13 @@
+{
+  "extends": "../../tsconfig.base.json",
+  "include": ["test/**/*.ts"],
+  "exclude": ["test/fixtures/**"],
+  "compilerOptions": {
+    "noEmit": true,
+    "allowJs": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "rewriteRelativeImportExtensions": true
+  },
+  "references": [{ "path": "../astro/tsconfig.test.json" }]
+}