fix(core): reload CSS#15259
Conversation
🦋 Changeset detectedLatest commit: cdcb076 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/kv-asset-handler | trusted-with-provenance | none |
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
|
The failing test here might be wrong, we might have been omiting those styles previously when we shouldn't have. |
| await environment?.runner?.import(componentPageId); | ||
| const resolved = await environment?.pluginContainer.resolveId(componentPageId); | ||
| if (ssrEnvironment && isRunnableDevEnvironment(ssrEnvironment)) { | ||
| await ssrEnvironment.runner?.import(componentPageId); |
There was a problem hiding this comment.
So this will never run on CF. Isn't it an issue?
There was a problem hiding this comment.
Well, that's the constraint of the CF environment. There isn't much we can do. We can't leverage caching.
I tried using the astro environment, but it has a bigger impact and requires many changes
3 participants
Changes
Closes #15194
The code was trying to run
runner.importusing the wrong vite environment.runner.importdoesn't function when the environment is non-runnable. SSR is non-runnable when using the cloudflare vite pluginTesting
Manually tested.
CI should stay green
Docs
N/A