Skip to content

fix(assets): hoist ?? inside JSON.stringify in virtual module codegen #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Princesseuh merged 2 commits into from
Jan 8, 2026
Merged

fix(assets): hoist ?? inside JSON.stringify in virtual module codegen #15140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
823befd
fix(assets): hoist nullish coalescing inside JSON.stringify
cameronraysmith Jan 8, 2026
5beaf2b
chore: add changeset
cameronraysmith Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-nullish-coalescing-codegen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes esbuild warning due to dead code in assets virtual module
8 changes: 4 additions & 4 deletions packages/astro/src/assets/vite-plugin-assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,12 @@ export default function assets({ fs, settings, sync, logger }: Options): vite.Pl
import * as fontsMod from 'virtual:astro:assets/fonts/internal';
import { createGetFontData } from "astro/assets/fonts/runtime";

export const viteFSConfig = ${JSON.stringify(resolvedConfig.server.fs)} ?? {};
export const viteFSConfig = ${JSON.stringify(resolvedConfig.server.fs ?? {})};

export const safeModulePaths = new Set(${JSON.stringify(
// @ts-expect-error safeModulePaths is internal to Vite
Array.from(resolvedConfig.safeModulePaths),
)} ?? []);
Array.from(resolvedConfig.safeModulePaths ?? []),
)});

const assetQueryParams = ${
settings.adapter?.client?.assetQueryParams
Expand Down