Skip to content

fix: remove useless tests #14854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 1 commit into from
Nov 21, 2025
Merged

fix: remove useless tests #14854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 2 additions & 50 deletions packages/astro/test/astro-pageDirectoryUrl.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import assert from 'node:assert/strict';
import { Writable } from 'node:stream';
import { before, describe, it } from 'node:test';
import { Logger } from '../dist/core/logger/core.js';
import { loadFixture } from './test-utils.js';

describe('build format', () => {
describe('build.format: file', () => {
/** @type {import('./test-utils.js').Fixture} */
let fixture;
const logs = [];

before(async () => {
fixture = await loadFixture({
Expand All @@ -17,41 +14,19 @@ describe('build format', () => {
format: 'file',
},
});
await fixture.build({
logger: new Logger({
level: 'info',
dest: new Writable({
objectMode: true,
write(event, _, callback) {
logs.push(event);
callback();
},
}),
}),
});
await fixture.build();
});

it('outputs', async () => {
assert.ok(await fixture.readFile('/client.html'));
assert.ok(await fixture.readFile('/nested-md.html'));
assert.ok(await fixture.readFile('/nested-astro.html'));
});

it('logs correct output paths', () => {
assert.ok(logs.find((log) => log.level === 'info' && log.message.includes('/client.html')));
assert.ok(
logs.find((log) => log.level === 'info' && log.message.includes('/nested-md.html')),
);
assert.ok(
logs.find((log) => log.level === 'info' && log.message.includes('/nested-astro.html')),
);
});
});

describe('build.format: preserve', () => {
/** @type {import('./test-utils.js').Fixture} */
let fixture;
const logs = [];

before(async () => {
fixture = await loadFixture({
Expand All @@ -60,36 +35,13 @@ describe('build format', () => {
format: 'preserve',
},
});
await fixture.build({
logger: new Logger({
level: 'info',
dest: new Writable({
objectMode: true,
write(event, _, callback) {
logs.push(event);
callback();
},
}),
}),
});
await fixture.build();
});

it('outputs', async () => {
assert.ok(await fixture.readFile('/client.html'));
assert.ok(await fixture.readFile('/nested-md/index.html'));
assert.ok(await fixture.readFile('/nested-astro/index.html'));
});

it('logs correct output paths', () => {
assert.ok(logs.find((log) => log.level === 'info' && log.message.includes('/client.html')));
assert.ok(
logs.find((log) => log.level === 'info' && log.message.includes('/nested-md/index.html')),
);
assert.ok(
logs.find(
(log) => log.level === 'info' && log.message.includes('/nested-astro/index.html'),
),
);
});
});
});
Loading