Skip to content

fix(create-astro): deprecation warning #14528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 13, 2025
Merged

fix(create-astro): deprecation warning #14528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aa5df79
fix(create-astro): deprecation warning
florian-lefebvre Oct 13, 2025
7669da2
Discard changes to packages/create-astro/src/actions/context.ts
florian-lefebvre Oct 13, 2025
3f5d2f0
Discard changes to packages/create-astro/src/actions/dependencies.ts
florian-lefebvre Oct 13, 2025
3fd406b
Discard changes to packages/create-astro/src/actions/git.ts
florian-lefebvre Oct 13, 2025
c1949d5
Discard changes to packages/create-astro/src/actions/next-steps.ts
florian-lefebvre Oct 13, 2025
8cad930
Discard changes to packages/create-astro/src/actions/project-name.ts
florian-lefebvre Oct 13, 2025
fbbceba
Discard changes to packages/create-astro/src/actions/template.ts
florian-lefebvre Oct 13, 2025
048ccc1
fix
florian-lefebvre Oct 13, 2025
62ffea8
Merge branch 'main' into fix/create-astro-deprecation-warning
florian-lefebvre Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-news-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': patch
---

Fixes a case where a deprecation warning would be shown on Node 24
4 changes: 2 additions & 2 deletions packages/create-astro/src/actions/project-name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import type { Context } from './context.js';
import { isEmpty, toValidName } from './shared.js';

export async function projectName(
ctx: Pick<Context, 'cwd' | 'yes' | 'dryRun' | 'prompt' | 'projectName' | 'exit'>,
ctx: Pick<Context, 'yes' | 'dryRun' | 'prompt' | 'projectName' | 'exit'> & { cwd?: string },
) {
await checkCwd(ctx.cwd);

if (!ctx.cwd || !isEmpty(ctx.cwd)) {
if (!isEmpty(ctx.cwd)) {
if (ctx.cwd && !isEmpty(ctx.cwd)) {
await info('Hmm...', `${color.reset(`"${ctx.cwd}"`)}${color.dim(` is not empty!`)}`);
}

Expand Down
Loading