Skip to content

fix: remove checkout step in mergeability check#14454

Merged
delucis merged 3 commits into
withastro:mainfrom
upsuper-forks:merge-checkout
Oct 15, 2025
Merged

fix: remove checkout step in mergeability check#14454
delucis merged 3 commits into
withastro:mainfrom
upsuper-forks:merge-checkout

Conversation

@upsuper
Copy link
Copy Markdown
Contributor

@upsuper upsuper commented Sep 29, 2025

Changes

Based on tj-actions/changed-files's README, checkout files in advance isn't necessary. I suspect the extra checkout step may be the cause of errors like https://github.com/withastro/astro/actions/runs/18036175690/job/51485929418?pr=14441

Testing

Change to GitHub workflow.

Docs

Bug fix for GitHub workflow, no effect on any package.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: 6a47301

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the 🚨 action Modifies GitHub Actions label Sep 29, 2025
@upsuper upsuper changed the title Remove checkout step in mergeability check fix: remove checkout step in mergeability check Sep 30, 2025
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can try this and see if it works 👍

The changed-files action docs mention “A maximum of 3000 files can be returned” but that seems like a pretty high limit, so not sure we’re that likely to hit it.

Could you update branch as well? Or give us permissions to edit this PR?

Comment thread .github/workflows/check-merge.yml Outdated
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@upsuper
Copy link
Copy Markdown
Contributor Author

upsuper commented Oct 14, 2025

Could you update branch as well?

What do you mean by updating branch? I've committed the change you suggested.

Or give us permissions to edit this PR?

I do want to and I thought it was always enabled until I realized that a PR created from a fork in an org can't grant that permission currently (see a relevant discussion). I may need to revisit how I manage all the forks.

@upsuper
Copy link
Copy Markdown
Contributor Author

upsuper commented Oct 14, 2025

I see what do you mean by update branch. I've hit the button to merge in main.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect — thanks @upsuper! I’ll merge and we can see if it works 🙂

@delucis delucis merged commit 4632db3 into withastro:main Oct 15, 2025
19 checks passed
@upsuper upsuper deleted the merge-checkout branch October 15, 2025 08:58
@delucis
Copy link
Copy Markdown
Member

delucis commented Oct 15, 2025

Updated branch in a PR to test it and seemed to work OK! https://github.com/withastro/astro/actions/runs/18523453176/job/52788590688?pr=14541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Modifies GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants