Fix cookies set after middleware called next(url) not being…#13740
Merged
ematipico merged 1 commit intowithastro:mainfrom May 2, 2025
Merged
Fix cookies set after middleware called next(url) not being…#13740ematipico merged 1 commit intowithastro:mainfrom
next(url) not being…#13740ematipico merged 1 commit intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7b923fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13740 will not alter performanceComparing Summary
|
vixalien
force-pushed
the
wip/vixalien/cookies-next-rewrite
branch
from
1c1367c to
7b923fa
Compare
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
… applied (withastro#13740) Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13723
Changes
next(url)and subsequent code changed cookies, those cookies would not be savedAstroCookiesinstance was setup, but when rendering the response, it used the previouscookiesvalue.Testing
Docs
/cc @withastro/maintainers-docs for feedback!