Skip to content

Conversation

@Marabyte
Copy link
Contributor

@Marabyte Marabyte commented Jan 9, 2025

Changes

Testing

In examples/frameworks-preact linked @preact/preset-vite to the workspace and manually tested Astro with Preact

Docs

No need to update docs

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 9effc1d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Jan 9, 2025
@ascorbic
Copy link
Contributor

Thanks. Can you look into why the tests are failing?

@Marabyte
Copy link
Contributor Author

Thanks. Can you look into why the tests are failing?

Yeah, taking a look now!

@bluwy
Copy link
Member

bluwy commented Jan 10, 2025

It's failing because of this

"@preact/preset-vite", // v2.8.3 starts to use Vite's esbuild for perf, but this conflicts with the react plugin

@florian-lefebvre florian-lefebvre changed the title chore: bump @preact/preset-vite to version 2.9.4 chore(preact): upgrade @preact/preset-vite Jan 31, 2025
@florian-lefebvre florian-lefebvre merged commit c497491 into withastro:main Feb 3, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Issues with peer dependencies found" when installing @astrojs/preact

5 participants