astro:assets image service bundle regression #9059
Description
git bisect start
# status: waiting for both good and bad commits
# bad: [1e97708cda779510d638abaefdb4abf707b697e3] fix: added onError functionality to spinner (#9048)
git bisect bad 1e97708cda779510d638abaefdb4abf707b697e3
# status: waiting for good commit(s), bad commit known
# good: [653ad939ce9f0ba12e2ce79a4cf9c154302b0bb9] [ci] release (#8989)
git bisect good 653ad939ce9f0ba12e2ce79a4cf9c154302b0bb9
# good: [4e63467d74e5b0b0eba1c80772e4daf64ff2b2d1] Remove empty changeset (#9030)
git bisect good 4e63467d74e5b0b0eba1c80772e4daf64ff2b2d1
# bad: [83c88706848521922ccd9cbdd914b653e47309db] [ci] release (#9021)
git bisect bad 83c88706848521922ccd9cbdd914b653e47309db
# bad: [3e1239e42b99bf069265393dc359bf967fc64902] Content Collection cache (experimental) (#8854)
git bisect bad 3e1239e42b99bf069265393dc359bf967fc64902
# good: [bd2d494c04ca48c6a496078b650e3c49bf243390] fix(config types): routingStrategy is optional (#9034)
git bisect good bd2d494c04ca48c6a496078b650e3c49bf243390
# good: [5b16619e4ad9bbbf7a1519899b7f5dd1b850562a] fix(i18n): names of the functions should match the RFC (#9035)
git bisect good 5b16619e4ad9bbbf7a1519899b7f5dd1b850562a
# first bad commit: [3e1239e42b99bf069265393dc359bf967fc64902] Content Collection cache (experimental) (#8854)Starting from this commit, the image service is (seemingly) getting wrongly bundled into SSR code even though it's unused, using the following "userland" image config.
https://github.com/withastro/adapters/pull/58/files
- the image service is (knowingly) incompatible with Cloudflare runtime,
- but they only use it on prerendered pages, so it should only be there at build
- so they set an empty endpoint (since that should be the only runtime code using the image service)
This worked in <3.4.4, broken in >3.5.0
https://github.com/alexanderniebuhr/astro-bug-debug