-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@solid-js/router working in build and preview but not in dev #4871
Comments
Seems like this library is not intended to be used on the server. Can you use |
I am just confused, why the build and preview works as expected, but not the dev? And therefore was wondering what the difference between those two configs are (though that is quite substantial i believe :) Having been digging around for the cloudflare adapter I realized that the platform for building solid needs to be |
Bro I faced 2 critical issues related to Astro in SolidJS cooperation. The truth is - Astro is more focused in React and Preact development, so SolidJS is like child from another family here :/ Astro is great and promising, but pararell evolving with such different framework plugins is not so eazy |
@DevHusariaSolutions I mainly am trying to fix the ssr functionality at the moment. And while i totally get the focus on more widely used frameworks i see astro as a big opportunity for solid to shine. Also astro does save a lot of time in then project, therefore i am good with helping to improve it as well.
funny because to big extend netlify seems to be pushing both of them astro and solidjs |
@DevHusariaSolutions It's not true that Astro is focused on other frameworks. We treat all of our integrations equally. Issues of the type: These types of issues are best fixed by members of the respective communities who understand the context better. I would love to make Solid.js libraries work better in Astro, but I don't have the luxury of stopping everything I'm doing to solely focus on that. I believe that Solid has more difficulties because libraries ship with untranspiled code. Vite 3 changed it so that dependencies are loaded through regular Node.js by default. This will cause any library that needs to be transpiled to fail. Using I'm not sure if that's the problem with this specific issue, however. |
I did play around with |
What version of
astro
are you using?1.3.0
Are you using an SSR adapter? If so, which one?
none
What package manager are you using?
pnpm
What operating system are you using?
Windows
Describe the Bug
When running the example simple routing with @solidjs/router example the workflow of
astro build
andastro preview
is running fine. Runningastro dev
is failing with the error:The error seems to originate from
solid-js/web
is imported with theserver
version which does not have aneffect
exported. I am struggling to find out why this is happening and how to work around it.Link to Minimal Reproducible Example
https://github.com/AirBorne04/minimal-astro-cloudflare-solid.git
Participation
The text was updated successfully, but these errors were encountered: