Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading @astrojs/mdx from 0.9.0 to 0.10.x breaks custom syntax highlighter that uses title metadata #4447

Closed
1 task
eliasbrange opened this issue Aug 23, 2022 · 1 comment

Comments

@eliasbrange
Copy link

eliasbrange commented Aug 23, 2022

What version of astro are you using?

1.0.0

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

yarn

What operating system are you using?

Windows (WSL 2)

Describe the Bug

Upgrading @astrojs/mdx from 0.9.0 to 0.10.x breaks the line highlighter in rehype-pretty-code. It uses metadata in the title such as

```typescript {1, 5-6}

Since I do not use the built-in astro highlighter, my guess is that rehypeRaw, which was added as default with the same PR (#4292) is causing some problems for me.

Working example (with @astrojs/mdx 0.9.0: https://stackblitz.com/edit/github-iyfzcn-zhr6ov

Non-working example (with @astrojs/mdx 0.10.1: https://stackblitz.com/edit/github-iyfzcn

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-iyfzcn

Participation

  • I am willing to submit a pull request for this issue.
@matthewp
Copy link
Contributor

matthewp commented Oct 6, 2022

Can you try again in @astrojs/mdx 0.11.x and create a new issue if it's still happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants