Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No testing on node LTS version 22 despite support #523

Open
1 task done
corneliusroemer opened this issue Jan 28, 2025 · 0 comments
Open
1 task done

No testing on node LTS version 22 despite support #523

corneliusroemer opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
- P2: nice to have Not breaking anything but nice to have (priority)

Comments

@corneliusroemer
Copy link

Astro Info

I noticed that you don't test on Node LTS version 22 despite it being officially supported.

Describe the Bug

Fix should be as easy as adding 22 here:

NODE_VERSION: [18, 20]

What's the expected result?

This is where you claim support for e.g. 22:

adapters/package.json

Lines 26 to 28 in 641d7d5

"engines": {
"node": "^18.17.1 || ^20.3.0 || >=21.0.0"
},

Link to Minimal Reproducible Example

None

Participation

  • I am willing to submit a pull request for this issue.
@ematipico ematipico added the - P2: nice to have Not breaking anything but nice to have (priority) label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority)
Projects
None yet
Development

No branches or pull requests

2 participants