Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare + Solid-js hydration / build errors. #263

Closed
1 task
wkelly17 opened this issue May 15, 2024 · 4 comments
Closed
1 task

Cloudflare + Solid-js hydration / build errors. #263

wkelly17 opened this issue May 15, 2024 · 4 comments
Labels
- P4: important Violate documented behavior or significantly improves performance (priority) pkg: cloudflare upstream

Comments

@wkelly17
Copy link

Astro Info

Astro                    v4.8.4
Node                     v21.5.0
System                   macOS (arm64)
Package Manager          pnpm
Output                   server
Adapter                  @astrojs/cloudflare
Integrations             @astrojs/solid-js

If this issue only occurs in one browser, which browser is a problem?

All

Describe the Bug

Can't run wrangler pages dev ./dist and get a reliable build when a component has any hydration directive that is not client:only="solid-js". The logs say, "✘ [ERROR] Uncaught (in response) TypeError: Cannot set properties of undefined (setting 'noHydrate')".
Min repro attached due to same error as reported by a member in discord. In my other project, I had @astrojs/solid-js 4.1.0 , @astrojs/cloudflare 10.2.4, astro 4.8.3 , solid-js 1.8.15. I downgraded to @astrojs/cloudflare 9+, but things reliably broke on any 10+ cloudflare adapter.

Discord link for futher viewing.
https://discord.com/channels/830184174198718474/1239920931510554655/1239920931510554655

What's the expected result?

Any hydration directive should build and work.

Link to Minimal Reproducible Example

https://github.com/wkelly17/astro-min-repro

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label May 15, 2024
@wkelly17 wkelly17 changed the title Cloudflare + Solid-js hydrations / build errors. Cloudflare + Solid-js hydration / build errors. May 16, 2024
@matthewp matthewp transferred this issue from withastro/astro May 16, 2024
@alexanderniebuhr alexanderniebuhr added pkg: cloudflare - P4: important Violate documented behavior or significantly improves performance (priority) and removed needs triage Issue needs to be triaged labels May 17, 2024
@alexanderniebuhr
Copy link
Member

Duplicate of #224, but I think your reproduction is a good addition to find the issue, so I'm gonna keep it open.

@alexanderniebuhr
Copy link
Member

I think I found the upstream issue: solidjs/vite-plugin-solid#153
This should be fixed in solid first, I would recommend trying to get someone on their discord to comment on it: https://publint.dev/[email protected]

@wkelly17
Copy link
Author

Ah, thanks. If anyone wants to chip in a few more details on the solid discord, or knows somewhere better to ask than support, here was my start of trying to figure it out there.
https://discord.com/channels/722131463138705510/1241033968317632635/1241033968317632635

@alexanderniebuhr
Copy link
Member

Duplicate of #224

@alexanderniebuhr alexanderniebuhr marked this as a duplicate of #224 May 27, 2024
@alexanderniebuhr alexanderniebuhr closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly improves performance (priority) pkg: cloudflare upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants