Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netlify adapter, can't opt out image service #118

Closed
1 task
ematipico opened this issue Dec 29, 2023 · 3 comments
Closed
1 task

Netlify adapter, can't opt out image service #118

ematipico opened this issue Dec 29, 2023 · 3 comments
Labels
pkg: netlify

Comments

@ematipico
Copy link
Member

Astro Info

main

Describe the Bug

The new version of Netlify adapter doesn't allow to opt out of the image service used by Netlify.

What's the expected result?

Like the Vercel adapter, I would expect an option, because the Netlify image service doesn't support remote patterns out of the box.

Link to Minimal Reproducible Example

None

Participation

  • I am willing to submit a pull request for this issue.
@alexanderniebuhr
Copy link
Member

I agree, having a option to opt-in / opt-out would be preferable.

cc @Skn0tt

@Skn0tt
Copy link
Contributor

Skn0tt commented Jan 2, 2024

Agreed! I'll work on this.

@Skn0tt Skn0tt mentioned this issue Jan 2, 2024
Merged
@Skn0tt
Copy link
Contributor

Skn0tt commented Jan 2, 2024

Here's the PR: #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: netlify
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ematipico @Skn0tt @alexanderniebuhr