Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconsider lock type #15

Open
smcquay opened this issue Sep 13, 2017 · 0 comments
Open

reconsider lock type #15

smcquay opened this issue Sep 13, 2017 · 0 comments
Labels
enhancement

Comments

@smcquay
Copy link
Contributor

smcquay commented Sep 13, 2017

I don't believe that pointers are what we want here:

https://github.com/ContextLogic/eventmaster/blob/331be5b624ea02fb5e0ebea21fc30385b3610f6e/event_store.go#L86

since the method receivers on EventStore are already pointers the extra indirection is superfluous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smcquay