Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEditor 5 integration is leaking memory #459

Closed
oleq opened this issue Nov 4, 2021 · 2 comments · Fixed by #469
Closed

CKEditor 5 integration is leaking memory #459

oleq opened this issue Nov 4, 2021 · 2 comments · Fixed by #469
Labels
browser:chrome Issues that can be reproduced on Chrome browser:safari Issues that can be reproduced on Safari package:ckeditor5 Issues involving the plugin for CKEditor 5 state:accepted We'll work on this issue soon type:bug Something isn't working

Comments

@oleq
Copy link
Contributor

oleq commented Nov 4, 2021

Description

Hi, I'm a core developer of CKEditor 5 👋

I'd like to inform you that the MathType plugin for the CKEditor 5 retains (lots of) memory when the editor is destroyed. This has been brought to our team's attention by our community and causes issues with integrations that re-start the editor a lot and/or use lots of editor instances on the same page.

Environment

  • Version: "@wiris/mathtype-ckeditor5": "^7.24.0",
  • CKEditor 5
  • Tested in Chrome on Mac

Steps to reproduce

  1. Close all Chrome windows.
  2. Run Chrome with a guest profile (free of add-ons, etc.), on Mac this would be /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --guest --js-flags="--expose-gc"
  3. Configure CKEditor 5 without MathType.
  4. Initialize the editor, then destroy it a couple of times. Click the Garbage Collector button after each destruction. Make sure no references are left behind (such as window.editor).
  5. Take a memory snapshot.
  6. Repeat 4.-5. a couple of times.
  7. Configure CKEditor 5 with MathType enabled.
  8. Repeat 4.-5. a couple of times.

Expected result

There should be no dramatic difference in snapshot size and retained memory.

Actual result

The presence of the MathType causes the editor to leak memory which is retained after each destruction.

Screenshot 2021-11-04 at 09 50 46

Other details

Related issues in CKEditor 5:

@oleq oleq added the type:bug Something isn't working label Nov 4, 2021
@carla-at-wiris carla-at-wiris added browser:chrome Issues that can be reproduced on Chrome browser:safari Issues that can be reproduced on Safari package:ckeditor5 Issues involving the plugin for CKEditor 5 state:accepted We'll work on this issue soon labels Nov 5, 2021
@carla-at-wiris
Copy link
Contributor

Hello @oleq,

Thank you so much for the information and for reporting the issue. We've added it on our backlog and will start working on it as soon as we can.

@icaparros-at-wiris
Copy link
Contributor

Hi @oleq,

We are happy to inform you that this issue has been fixed in the 7.28.0 version.

We are proceding to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome Issues that can be reproduced on Chrome browser:safari Issues that can be reproduced on Safari package:ckeditor5 Issues involving the plugin for CKEditor 5 state:accepted We'll work on this issue soon type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants