Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cache a parameter to Analysis constructor #14

Open
ghing opened this issue Jan 11, 2016 · 2 comments
Open

Make cache a parameter to Analysis constructor #14

ghing opened this issue Jan 11, 2016 · 2 comments

Comments

@ghing
Copy link

ghing commented Jan 11, 2016

There are often cases where multiple reporters, with different skillsets, will be working on analysis in parallel. Often the common language is a SQL database. It would be cool to be able to replace the disk-based Pickle cache with a cache that is storing the data to SQL tables. This is outside the scope of proof, but parameterizing the cache would let people write their own cache implementations.

@ghing
Copy link
Author

ghing commented Jan 11, 2016

Actually, that use case is a bad idea. It would be better to have an analysis step that does the database refresh. Still, parameterizing the cache doesn't seem like a bad idea.

@onyxfish
Copy link
Collaborator

This sounds like a nifty idea, though I think it might be a little hard to bolt on a backend as radically different as SQL is. The data stored in proof is not, strictly speaking, tables. Its just a dict of whatever. I suppose you could simply say by convention that each key is a table. In that case your custom cache layer could use agate-sql for the heavy lifting.

I think for common usage it probably makes more sense for backends to be generic binary stores. That doesn't rule out alternative implementations, though super-useful ones don't spring immediately to mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants