-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csvjoin: Implement case-insensitive key comparison #610
base: master
Are you sure you want to change the base?
Conversation
@@ -10,3 +10,4 @@ docs/_build | |||
.coverage | |||
.tox | |||
cover | |||
env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for a virtualenv, but let me know if you have another convention you strongly prefer.
Instead of making this an option that only applies to |
@jpmckinney this PR doesn't actually seem to be about headers? |
@fgregg You're right - not sure what I was thinking in 2016 😅 |
709f226
to
e5ef16e
Compare
@fgregg Is this the sort of think that |
csvlink is not a good fit for this. one thing i’ve often wished for is passing a little code into csvpy on the command line that could make this really composable something like csvpy -c identifier -p “d.lower()” example.csv |
This is much nicer than lowercasing files to do the join then trying to restore case that's important later on.
Thanks for the great tools!