diff --git a/changelog.d/4-docs/hotfix-pr-guidelines b/changelog.d/4-docs/hotfix-pr-guidelines new file mode 100644 index 0000000000..940c66b8ff --- /dev/null +++ b/changelog.d/4-docs/hotfix-pr-guidelines @@ -0,0 +1 @@ +Adding a testing config entry to the PR guidelines. \ No newline at end of file diff --git a/docs/src/developer/developer/pr-guidelines.md b/docs/src/developer/developer/pr-guidelines.md index be0bf1f01b..09b7e37fd2 100644 --- a/docs/src/developer/developer/pr-guidelines.md +++ b/docs/src/developer/developer/pr-guidelines.md @@ -87,6 +87,9 @@ If a PR adds new configuration options for say brig, the following files need to * [ ] The values files for CI: `hack/helm_vars/wire-server/values.yaml.gotmpl` * [ ] The configuration docs: `docs/src/developer/reference/config-options.md` +Additional configuration may also exist for services in the following locations. +* [ ] `charts/$SERVICE/templates/tests/configmap.yaml` + If any new configuration value is required and has no default, then: * [ ] Write a changelog entry in `0-release-notes` advertising the new configuration value