From e2f6e72bf2b0e3080eff8b5005fcd5500d848597 Mon Sep 17 00:00:00 2001 From: jschaul Date: Wed, 5 Apr 2023 15:19:11 +0200 Subject: [PATCH] Coturn helm chart: Increase liveness timeout Increase default of liveness/readiness probe and make it configurable. Under high load, the default of failureThreshold=3 timeoutSeconds=1 can lead to restarts of the coturn pod due to the http port being temporarily starved of CPU, leading to an unnecessary restart of the coturn pods. This change should make this less frequent and improve call stability. --- changelog.d/3-bug-fixes/coturn-liveness | 1 + charts/coturn/templates/statefulset.yaml | 4 ++++ charts/coturn/values.yaml | 8 ++++++++ 3 files changed, 13 insertions(+) create mode 100644 changelog.d/3-bug-fixes/coturn-liveness diff --git a/changelog.d/3-bug-fixes/coturn-liveness b/changelog.d/3-bug-fixes/coturn-liveness new file mode 100644 index 0000000000..528c011b0a --- /dev/null +++ b/changelog.d/3-bug-fixes/coturn-liveness @@ -0,0 +1 @@ +Coturn helm chart: Increase the default timeout of liveness/readiness probe and make it configurable diff --git a/charts/coturn/templates/statefulset.yaml b/charts/coturn/templates/statefulset.yaml index 37ce6aef3e..c66b0aa643 100644 --- a/charts/coturn/templates/statefulset.yaml +++ b/charts/coturn/templates/statefulset.yaml @@ -143,11 +143,15 @@ spec: protocol: TCP livenessProbe: + timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }} + failureThreshold: {{ .Values.livenessProbe.failureThreshold }} httpGet: path: / port: status-http readinessProbe: + timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }} + failureThreshold: {{ .Values.readinessProbe.failureThreshold }} httpGet: path: / port: status-http diff --git a/charts/coturn/values.yaml b/charts/coturn/values.yaml index 30bc42b470..a3b2c13f9e 100644 --- a/charts/coturn/values.yaml +++ b/charts/coturn/values.yaml @@ -53,3 +53,11 @@ coturnGracefulTermination: false # terminated. This setting is only effective when coturnGracefulTermination is # set to true. coturnGracePeriodSeconds: 86400 # one day + +livenessProbe: + timeoutSeconds: 5 + failureThreshold: 5 + +readinessProbe: + timeoutSeconds: 5 + failureThreshold: 5