diff --git a/changelog.d/4-docs/pr-2889 b/changelog.d/4-docs/pr-2889 new file mode 100644 index 0000000000..a4f811ceb8 --- /dev/null +++ b/changelog.d/4-docs/pr-2889 @@ -0,0 +1 @@ +PR guidelines docs are updated with correct helm configuration syntax diff --git a/docs/src/developer/developer/pr-guidelines.md b/docs/src/developer/developer/pr-guidelines.md index 60acfaab6e..ab30aef251 100644 --- a/docs/src/developer/developer/pr-guidelines.md +++ b/docs/src/developer/developer/pr-guidelines.md @@ -44,10 +44,13 @@ The following needs to be done, as part of a PR adding endpoints or changing end ### Helm configuration For internal endpoints for QA access on staging environments, copy a block with `/i/` containing + ``` -zauth: false -basic_auth: true -whitelisted_envs: ['staging'] + - path: /some/path + envs: + - staging + disable_zauth: true + basic_auth: true ``` For customer support access to an internal endpoint, instead update code in [stern](https://github.com/wireapp/wire-server/tree/develop/tools/stern) as part of your PR. There is no need to add that endpoint to nginz.